-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add status updates for interactions in the student view #26
Conversation
@mariajgrimaldi, When I try to delete a student's status I get the following error File "/openedx/edx-platform/lms/djangoapps/instructor/enrollment.py", line 382, in _fire_score_changed_for_block
max_score = block.max_score()
TypeError: 'int' object is not callable Apparently |
@BryanttV: thanks! Can you try again? |
Now it works fine! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@mariajgrimaldi could you please rebase it with master? |
e3bf413
to
399d1e0
Compare
@mariajgrimaldi, By default, the score displayed is always (1.0/x.0), in this case: (1.0/100.0). Shouldn't the score be 0? |
@BryanttV: check again :) |
@mariajgrimaldi, Perfect, LGTM! |
Description
This PR adds new fields to inform students about their interaction status with the problem. Have they answered? What's their score? Since some H5P components do not explicitly show this.
We decided to use two states:
Not attempted
: the defaultCompleted
: when a student submits a problem, the status is updated to this one.When the instructor cleans the student status, the state resets to
Not attempted
. Regarding the score, we're currently showing what the H5P content returns as raw score and max score. When the problem is not scored, then just the submission status is shown.How to test
Where the max score is the one configured in the Studio Edit view. When the problem is not scored, then nothing is shown.